When I use the WP image uploader to insert an image into my post with a caption, the caption functionality doesn't work. WP just spits out the image followed by the caption with no formatting whatsoever. See here (the caption on the first image in the post is "test"):
http://justinis.com/wordpress/trouble-on-the-farm-why-youre-paying-brazilian-cotton-farmers/
Is there a way to fix this? I would like to use WP's easy, built-in method of adding images with captions. I am using BigFeature 1.4.2.3
vfxdude
admin
The caption background color and text color is set in the theme settings (color tab). The default caption style is one with a background color, but here it's set to white so it seams like it's not there. There are also other caption styles that can be selected in the theme settings ("Image Caption Style" dropdown list).
Thanks but that's not really what I'm getting at. Next to the image of the two pyramids titled "Why does a salad cost more than a big mac?" you will see the word "test." This is the caption I made for the image using the WP image uploader. In the source code there is no span or div surrounding this caption so there is no way I can style it. I set the image to be centered before I inserted it as well and it's not centered in the post. It looks like the WP caption code screws everything up.
Here is a screenshot of how the image looks in the post editor:
https://dl.dropbox.com/u/26558331/screenshot.jpg
Captions seem to work fine for the featured image but not for images inserted into posts.
vfxdude
admin
When inserting an image with a caption, the caption shortcode is used, example:
[caption id="attachment_705" align="aligncenter" width="283"]<img src="image.jpg" alt="" title="image" /> test[/caption]
When I tested this now, it worked fine and there was nothing wrong with the styling. It produced this code:
<div style="width: 293px" class="wp-caption aligncenter" id="attachment_705">
<img title="image" alt="" src="image.jpg" /><p class="wp-caption-text">test</p></div>Check the html view of the editor that it's the same syntax used for the shortcode. If it is, then there is a problem with this shortcode in your installation, maybe caused by a plugin.
You can also use the image shortcode to show captions.
vfxdude
admin
Should I actually remove all my plugins rather than just deactivate?deactivating the plugins is enough.
Test the shortcode in a page. Just create a page and copy the shortcode in and view the page, this is to see if there is a problem with the single post template. Also test other shortcodes in the post to see if they work.
Nope, doesn't work. http://justinis.com/wordpress/test/
Here is the shortcode I used: https://dl.dropbox.com/u/26558331/shortcode.txt
Every bigfeature shortcode I have used works. But I really want to use the built-in WP caption capability cause it's so convenient.
vfxdude
admin
This turns out to be a Wordpress 3.4 issue. If you set the "Image Caption Style" to the "Default Style", in the theme settings, wordpress captions will work. As soon as I change this to another style I get the same as you.
Here's how to fix it:
edit library/functions/shortcodes.php
remove these 4 lines:
if ($bf_default_caption !== 'default') {
add_shortcode('wp_caption', 'bf_image_caption');
add_shortcode('caption', 'bf_image_caption');
}
legshooter
Member
I have the same problem (I think). Changing image caption style in the settings tab has absolutely no affect. I upgraded to 1.5, and those lines appear to have disappeared from shortcodes.php - I'm guessing because you fixed the problem, but I'm still having it. Help please?
vfxdude
admin
I have the same problem (I think). Changing image caption style in the settings tab has absolutely no affect.Inserted captions only uses the wp style, changing the caption styles in the theme settings should not work anymore, that's only for default/featured images. You need to describe the problem a bit more (screenshot helps).
legshooter
Member
I routinely update my site by adding a new post, adding text to it and inserting an image beside the text.
Post for example: http://www.a-read.com/alguard/
changing the caption styles in the theme settings should not work anymore
vfxdude
admin
Post for example: http://www.a-read.com/alguard/The image with caption there is transparent, so it might seem like there's no caption styling, since the image will take on the same color as the caption area (and frame).
So what you're saying is that I have no way of styling all these images I have inside my posts all at once, like I used to have with the "image caption style"?That's not what I am saying, they can be styled with css.
They all just went back to some default style, and except for styling them all one by oneA css style changes everything, so there's no need to change the post.
Here's examples of styling the inserted captions with css:
css3 style like shown here:
.wp-caption {
padding: 4px 4px 0 4px;
border: 1px solid #ccc;
color: #555;
background: #f9f9f9;
-moz-box-shadow: 1px 1px 5px rgba(153, 153, 153, 0.3);
-webkit-box-shadow: 1px 1px 5px rgba(153, 153, 153, 0.3);
box-shadow: 1px 1px 5px rgba(153, 153, 153, 0.3);
-moz-border-radius: 5px; -webkit-border-radius: 5px; border-radius: 5px;
}Bottom bg color caption:
.wp-caption {
background-color: transparent;
border: none;
border-radius: 0;
padding: 0;
}
.wp-caption p.wp-caption-text { background-color: #333; color: #fff; }Change the padding in the .wp-caption for frame style: padding: 4px 4px 0 4px;
I might recode the function that WP3.4 messed up, so the caption styles in the theme settings will work again, but as shown above most of the styles can be added with css too.
legshooter
Member
argh, that's exactly what I meant - if it's still possible to control through the theme settings, without playing with the CSS :)
I would LOVE it if you fix that messed up function, I was silently waiting for it to be back in action in ver 1.5. Guess I was too silent :)
Thanks!
I'm guessing you got mixed up in your code(?) - you wrote .wp-caption twice in a row, resetting the second time everything you already set the first time.
vfxdude
admin
I was silently waiting for it to be back in action in ver 1.5. Guess I was too silent :)I guess so. I forgot about it.
Anyway, I looked into it now, and the fix was easy. Here's how:
edit library/functions/shortcodes.php
remove this line:
$output = apply_filters('img_caption_shortcode', '', $attr, $content);
then add this filter function to shortcodes.php (after the bf_image_caption function):
function bf_image_caption_filter($output, $attr, $content) {
if (is_feed()) return $output;
if ($bfcaption = bf_image_caption($attr, $content)) return $bfcaption;
return $output;
}
add_filter( 'img_caption_shortcode', 'bf_image_caption_filter', 10, 3 );You must log in to post.